On Tue, 03 Feb 2015, Jes Sorensen wrote: > Nicholas Mc Guire <hofrat@xxxxxxxxx> writes: > > A number if/else if/else branches are identical - so the condition has no > > effect on the effective code and can be significantly simplified - this > > patch removes the condition and the duplicated code. > > > > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx> > > --- > > > > This looks like the output of some broken code-generator - unlikely someone > > wrote this by hand. In any case it needs a review by someone that knows the > > details of the driver. > > > > Anyway the number of useless code repetition is potentially record breaking ! > > > > Patch was compile tested for x86_64_defconfig + CONFIG_STAGING=y > > CONFIG_R8723AU=m, CONFIG_8723AU_BT_COEXIST=y > > > > Patch is against 3.0.19-rc7 (localversoin = -next-20150203) > > > > .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 60 +++----------------- > > 1 file changed, 8 insertions(+), 52 deletions(-) > > Why make it simple if you can make it complicated :) > > I presume it's against 3.19-rc7 since a 3.0.19 would be rather obsolete. > yes - thats a typo - sorry for that. > Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
