Re: [PATCH] staging: rtl8723au: core: rtw_mlme_ext: Removed variables that is never used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2015-02-01 23:58 GMT+01:00 Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>:
> Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> writes:
>> Variable was assigned a value that was never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
>> ---
>>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c |    7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> index 0e0f73c..7c60fed 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
>> @@ -2515,7 +2515,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
>>       unsigned char *mac, *bssid;
>>       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
>>  #ifdef CONFIG_8723AU_AP_MODE
>> -     const u8 *pwps_ie;
>>       u8 *ssid_ie;
>>       int ssid_ielen;
>>       int ssid_ielen_diff;
>> @@ -2576,7 +2575,7 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
>>
>>  #ifdef CONFIG_8723AU_AP_MODE
>>       if ((pmlmeinfo->state & 0x03) == MSR_AP) {
>> -             pwps_ie = cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
>> +             cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
>>                                                 WLAN_OUI_TYPE_MICROSOFT_WPS,
>>                                                 cur_network->IEs,
>>                                                 cur_network->IELength);
>
> If you want to modify this, you need to fix up the formatting to go with
> it.
>
> NACK
>

Hi

I am sorry, please ignore this.
I will not send any more patches.

Kind regards
Rickard Strandqvist
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux