The check for return of schedule_timeout() has no effect on the effective control flow of sleep_schedulable() so it can be dropped. Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx> --- The current codes return check for schedule_timeout() has no effect and can probably be dropped unless it is intended as a placeholder for some future change in which case a comment should probably be added. This patch was only compile tested for x86_64_defconfig + CONFIG_STAGING=y, CONFIG_R8712U=m Patch is against 3.0.19-rc6 -next-20150129 but depends on: [PATCH 1/2] staging: rtl8712: cleanup of timeout conversions drivers/staging/rtl8712/osdep_service.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index f933713..36348d9 100644 --- a/drivers/staging/rtl8712/osdep_service.h +++ b/drivers/staging/rtl8712/osdep_service.h @@ -103,8 +103,7 @@ static inline void sleep_schedulable(int ms) delta = msecs_to_jiffies(ms);/*(ms)*/ set_current_state(TASK_INTERRUPTIBLE); - if (schedule_timeout(delta) != 0) - return; + schedule_timeout(delta); } static inline unsigned char _cancel_timer_ex(struct timer_list *ptimer) -- 1.7.10.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
