As the if completes with a unconditional goto the else branch is not needed here. Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx> --- v2: added missing subsystem string in subject line - patch unchanged All paths of execution that did not exit through the if branch will go through the else branch so no need for an explicit else here Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m Patch is against 3.19.0-rc5 -next-20150123 drivers/net/hyperv/rndis_filter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 7bd8387..efb84a9 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct rndis_device *dev, u32 new_filter) * send completion for it. */ goto exit; - } else { - set_complete = &request->response_msg.msg.set_complete; - status = set_complete->status; - } + } + + set_complete = &request->response_msg.msg.set_complete; + status = set_complete->status; cleanup: if (request) -- 1.7.10.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel