Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> 
> netdev_info was used since it is a network subsystem
> 
> Signed-off-by: Heba Aamer <heba93aamer@xxxxxxxxx>
> ---
>  drivers/staging/rtl8712/usb_intf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>  	struct net_device *pnetdev;
>  	struct usb_device *udev;
>  
> -	printk(KERN_INFO "r8712u: Staging version\n");
> +	netdev_info(pnetdev, "r8712u: Staging version\n");
>  	/* In this probe function, O.S. will provide the usb interface pointer
>  	 * to driver. We have to increase the reference count of the usb device
>  	 * structure by using the usb_get_dev function.

Please don't send patches that you do not at least test-build, it's a
bit rude and wastes people's time.

Oh, and also ensure that your patch is correct, hint, this one does not
work at all :(

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux