On Sat, Jan 24, 2015 at 12:41:20AM +0530, jitendra kumar khasdev wrote: > This is patch to file jr3_pci.c that fix up warning line > over 80 character which is found by checkpatch tool. Made change into signature > of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline > so that 80 character line over warning to be reduced. The irony of not properly line-wrapping your changelog comment for a patch that you are fixing up proper line size is huge :) > > Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@xxxxxxxxx> > --- > drivers/staging/comedi/drivers/jr3_pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c > index 81fab2d..1de843d 100644 > --- a/drivers/staging/comedi/drivers/jr3_pci.c > +++ b/drivers/staging/comedi/drivers/jr3_pci.c > @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev, > return 0; > } > > -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s) > +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice > + *s) Be reasonable, this is now looks worse than the code did before, just leave this as-is, coding style is a guideline, not hard rules. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
