On Thu, Jan 22, 2015 at 10:05:53AM +0000, David Binderman wrote:
> Hello there,
>
> [linux-3.19-rc5/drivers/staging/dgap/dgap.c:981]: (warning) Logical disjunction always evaluates to true: conc_type != 65 || conc_type != 66.
>
> Source code is
>
> if (conc_type == 0 || conc_type != CX ||
> conc_type != EPC) {
>
> Suggest code rework.
Thanks. This bug was introduced in:
commit f6aa0164cd3b1c5192e87f5651ec382c3bc3abac
Author: Daeseok Youn <daeseok.youn@xxxxxxxxx>
Date: Sat Aug 9 14:38:41 2014 +0900
staging: dgap: Simplify to set a concentrator type
It is same manner with setting a board type.
For example of config file for concentrator,
"conc ccon" or
"conc epcon"
After allocating a type of "CNODE" then set a type of concentrator.
So remove cases in swith statement, just get a token from string
and set to "conc.type". And also it doesn't need to "conc.v_type".
Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Let's CC Daeseok.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
