On Tue, 20 Jan 2015, Ulf Hansson wrote: > On 20 January 2015 at 15:47, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Tue, 23 Dec 2014, micky_ching@xxxxxxxxxxxxxx wrote: > > > >> From: Micky Ching <micky_ching@xxxxxxxxxxxxxx> > >> > >> Add helper function to write u32 to registers, if we want to put u32 > >> value to 4 continuous register, this can help us reduce tedious work. > >> > >> Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx> > >> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > >> --- > >> include/linux/mfd/rtsx_pci.h | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > > > > Applied, thanks. > > This one has already been queued by you, for 3.19, and it's in Linus tree. :-) > > For your reference, I have queued the mmc patches which depends on > $subject patch for 3.20. I discovered this myself when I attempted to apply it. :) Thanks for the heads-up though. > >> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h > >> index 74346d5..9234449 100644 > >> --- a/include/linux/mfd/rtsx_pci.h > >> +++ b/include/linux/mfd/rtsx_pci.h > >> @@ -558,6 +558,7 @@ > >> #define SD_SAMPLE_POINT_CTL 0xFDA7 > >> #define SD_PUSH_POINT_CTL 0xFDA8 > >> #define SD_CMD0 0xFDA9 > >> +#define SD_CMD_START 0x40 > >> #define SD_CMD1 0xFDAA > >> #define SD_CMD2 0xFDAB > >> #define SD_CMD3 0xFDAC > >> @@ -967,4 +968,12 @@ static inline u8 *rtsx_pci_get_cmd_data(struct rtsx_pcr *pcr) > >> return (u8 *)(pcr->host_cmds_ptr); > >> } > >> > >> +static inline void rtsx_pci_write_be32(struct rtsx_pcr *pcr, u16 reg, u32 val) > >> +{ > >> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg, 0xFF, val >> 24); > >> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 1, 0xFF, val >> 16); > >> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 2, 0xFF, val >> 8); > >> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val); > >> +} > >> + > >> #endif > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel