Re: [PATCH 08/10] mfd: rtsx: add support for rts524A

[敬锐 <micky_ching@xxxxxxxxxxxxxx>]

On 01/18/2015 08:20 PM, Lee Jones wrote:
>> @@ -72,8 +72,10 @@ static void rts5249_fetch_vendor_settings(struct rtsx_pcr *pcr)
>> >  	rtsx_pci_read_config_dword(pcr, PCR_SETTING_REG1, &reg);
>> >  	dev_dbg(&(pcr->pci->dev), "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG1, reg);
>> >  
>> >-	if (!rtsx_vendor_setting_valid(reg))
>> >+	if (!rtsx_vendor_setting_valid(reg)) {
>> >+		pcr_dbg(pcr, "skip fetch vendor setting\n");
>> >  		return;
>> >+	}
> This doesn't have anything to do with adding the new chip.
>
> And I'm not sure it's even required.
>
Yes, it can be removed, but it is useful for debug,
help us to know whether config is load from hardware.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel