On Sat, Jan 17, 2015 at 08:00:09PM +1100, Zachary Warren wrote: > Avoids the following warnings from sparse: > visorchannel_funcs.c:457:9: warning: > context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block > visorchannel_funcs.c:512:9: warning: > context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic > > These warnings are false positives. The rework follows the suggestion from: > https://lkml.org/lkml/2013/10/17/398 > No one wants to follow a link to read the changelog. Just say explain like "I made a new wrapper around the function that does the locking if needed and removed the locking from inside the function." Otherwise the patch looks good. Could you re-write the changelog and resend? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
