Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 13, 2015 at 12:18:40PM +0530, Sudip Mukherjee wrote:
> On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > > > 
> > > > any reason why this return was removed ?
> > > 
> > > Because it's not needed.
> > 
> > yes, it is not needed. but the way Emrys Bayliss has changed the code, then we will get a compiler warning about no return statement.
> i should have mentioned in my last mail that compiler will give waring if we compile with W=3 
> 

1) Your compiler is crap.
2) You should ignore obviously incorrect warnings.

I'm using GCC 4.7.2 and it doesn't give a warning for this.  W=3 gives a
million other totally worthless warnings though.  W=3 is not useful.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux