Re: [PATCH] staging:vt6655 Add extern variable in head file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@xxxxxxxxx>
> 
> Subject: [PATCH] staging:vt6655 Add extern variable in head file

Why is this in the middle of the patch?  I would have to hand edit it
out :(

> 
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. 

Always wrap your changelog at 72 columns.

Please fix up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux