On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote:
> Use the normal logging facility instead of a new macro.
>
> Miscellanea:
>
> o Realign arguments
> o Remove unnecessary alloc error messages as alloc failures
> already emits a generic OOM message with a dump_stack
> o Add missing newlines to these messages to avoid interleaving
> o Spelling/typo fixes in those messages
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/staging/unisys/include/uisutils.h | 4 +-
> drivers/staging/unisys/uislib/uislib.c | 169 ++++++++++-----------
> drivers/staging/unisys/uislib/uisqueue.c | 4 +-
> drivers/staging/unisys/uislib/uisthread.c | 4 +-
> drivers/staging/unisys/uislib/uisutils.c | 34 ++---
> drivers/staging/unisys/virthba/virthba.c | 119 +++++++--------
> drivers/staging/unisys/virtpci/virtpci.c | 71 +++++----
> drivers/staging/unisys/visorchipset/file.c | 2 +-
> .../unisys/visorchipset/visorchipset_main.c | 159 ++++++++++---------
> 9 files changed, 276 insertions(+), 290 deletions(-)
>
> diff --git a/drivers/staging/unisys/include/uisutils.h b/drivers/staging/unisys/include/uisutils.h
> index 7414220..f937892 100644
> --- a/drivers/staging/unisys/include/uisutils.h
> +++ b/drivers/staging/unisys/include/uisutils.h
> @@ -206,10 +206,10 @@ wait_for_valid_guid(uuid_le __iomem *guid)
> (void __iomem *)guid, sizeof(uuid_le));
> if (uuid_le_cmp(tmpguid, NULL_UUID_LE) != 0)
> break;
> - LOGERR("Waiting for non-0 GUID (why???)...\n");
> + pr_err("Waiting for non-0 GUID (why???)...\n");
I rejected the other patch that did much this same thing, almost all of
these should be converted to use dev_* calls instead of pr_* calls, as
this is a driver, and drivers should always have access to a struct
device. If not, they need to be fixed.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
