On Thursday, January 08, 2015 3:52 AM, Ian Abbott wrote: > On 08/01/15 00:19, H Hartley Sweeten wrote: >> Tidy up this driver and add async command support for change-of-state >> detection of the digital inputs. >> >> H Hartley Sweeten (8): >> staging: comedi: aio_iiro_16: fix subdevice 0 'type' >> staging: comedi: aio_iiro_16: fix subdevice 1 'type' >> staging: comedi: aio_iiro_16: tidy up subdevice init >> staging: comedi: aio_iiro_16: tidy up multi-line comments >> staging: comedi: aio_iiro_16: read intial state of the digital outputs >> staging: comedi: aio_iiro_16: introduce aio_iiro_enable_irq() >> staging: comedi: aio_iiro_16: add command support for change of state detection >> staging: comedi: aio_iiro_16: update the MODULE_DESCRIPTION >> >> drivers/staging/comedi/drivers/aio_iiro_16.c | 219 ++++++++++++++++++++------- >> 1 file changed, 168 insertions(+), 51 deletions(-) >> > > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> Thanks. I was thinking about the async command support last night. Do you think it might be better to also return the current state of the digital inputs along with the interrupt status in the sample? With the current patch the user will get a sample indicating that a digital input has changed state and what group (inputs 0-7 and/or 8-15) but they will need to cancel the command in order to do an (*insn_bits) operation in order to check the inputs. I can either update the patch to do this or I can post a follow up patch. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
