On 1 January 2015 at 06:28, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: >> > i may be wrong, but looks like you are doing many different things in the patch, not just whitespace errors. >> > marked a few, please see inline - ... > sorry for not trimming that. I noticed the big size while sending, but at that time the damage has already been done. > but is it ok if we mention one thing in the commit log and do other things also? shouldn't we atleast mention that in the commit? Hi Sudip, I felt that 'additionally it removes inconsistent whitespace throughout.' covered these cases, given there's a lot I also felt it'd be more irritating for the community to receive several separate patches for each individual *sub* type of whitespace removal beyond those fixing checkpatch.pl messages, of course that kind of separation could get pretty big and these patches are already big enough as it is (this file had a lot of issues :) As someone who's new to kernel development I'd be more than happy to adjust this if the consensus is towards a different approach, however I feel this is the least painful means of doing this particular patch set. Best, Lorenzo _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
