On Tue, Dec 30, 2014 at 07:04:35PM -0800, Serguey Parkhomovsky wrote: > On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote: > > > > If you look at the source code just below these functions you will find: > > > > EXPORT_SYMBOL(libcfs_arch_init); > > EXPORT_SYMBOL(libcfs_arch_cleanup); > > > > So making these static is incorrect because they are being used outside > > of this file. > > > > Thanks for the review, and sorry about the noise; I'll be more careful next time. these tools are there to help you find the problems in the code.but after that we need to use our own judgement to decide. in this case the solution is to declare them in libcfs.h and please atleast buildtest your patch before sending. If you would have compiled this patch then you could have seen 2 new warnings: "WARNING: "libcfs_arch_init" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!" "WARNING: "libcfs_arch_cleanup" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!" thanks sudip > > Serguey > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
