thanks! I have a preference for the v2 I sent: my $EDITOR handles the indentation for me; using 2 tabs forces me to manually override my editor's behavior. But if there is a strong push for a v3 of this patch with 2 tabs instead of current v2 indentation, I'll do it, please let me know. On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote: >> Before: >> 1 ERROR: code indent should use tabs where possible >> 1 WARNING: please, no spaces at the start of a line >> >> After: >> (none) >> >> Signed-off-by: David Decotigny <ddecotig@xxxxxxxxx> >> --- >> drivers/staging/comedi/drivers/dmm32at.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c >> index 6df298a..31919b8 100644 >> --- a/drivers/staging/comedi/drivers/dmm32at.c >> +++ b/drivers/staging/comedi/drivers/dmm32at.c >> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec) >> /* enable the ai conversion interrupt and the clock to start scans */ >> outb(DMM32AT_INTCLK_ADINT | >> DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, >> - dev->iobase + DMM32AT_INTCLK_REG); >> + dev->iobase + DMM32AT_INTCLK_REG); > > another suggestion: > if you do like the following patch (use 2 tabs) then you do not need to give spaces to indent the code. > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c > index 6df298a..cedf8ed 100644 > --- a/drivers/staging/comedi/drivers/dmm32at.c > +++ b/drivers/staging/comedi/drivers/dmm32at.c > @@ -364,8 +364,8 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec) > > /* enable the ai conversion interrupt and the clock to start scans */ > outb(DMM32AT_INTCLK_ADINT | > - DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, > - dev->iobase + DMM32AT_INTCLK_REG); > + DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, > + dev->iobase + DMM32AT_INTCLK_REG); > } > > static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) > > > thanks > sudip > >> } >> >> static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) >> -- >> 2.2.0.rc0.207.ga3a616c >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
