Re: [PATCH 3/3] Staging: comedi: fix space and 80 char coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 29, 2014 at 03:14:45AM +0530, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up spcae and maximum
> character limit warning found by the checkpatch.pl tool

you are doing two different kind of changes in this patch. it should be in two different patches. One patch should do only one type of change.

thanks
sudip

> 
> Signed-off-by: Jitendra Kumar Khasdev  <jkhasdev@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/s626.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 14932c5..77f715b 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
>  static void s626_mc_disable(struct comedi_device *dev,
>  			    unsigned int cmd, unsigned int reg)
>  {
> -	writel(cmd << 16 , dev->mmio + reg);
> +	writel(cmd << 16, dev->mmio + reg);
>  	mmiowb();
>  }
>  
> @@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
>  	for (i = 0; i < 2; i++) {
>  		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
>  		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> -		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> +		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> +		0);
>  		if (ret)
>  			return ret;
>  	}
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux