Re: [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/26, Damon Swayn wrote:
> Fixed a coding style issue

You need to be more specific here, describe what kind of issue this
patch is fixing. Keep in mind that this message, when formulated
properly, will end up as a comment to the Linux kernel source - it must,
therefore, contain valuable information.

thanks,
konrad

ps: the file name does not have to be mentioned in the subject as this
information is already in the diff.
 
> Signed-off-by: Damon Swayn <damon.swayn@xxxxxxxx>
> ---
>  drivers/staging/line6/pcm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
> index 6aa0d46..5d87934 100644
> --- a/drivers/staging/line6/pcm.h
> +++ b/drivers/staging/line6/pcm.h
> @@ -145,21 +145,21 @@ enum {
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
>  
>  	LINE6_BITS_PLAYBACK_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
>  
>  	LINE6_BITS_CAPTURE_BUFFER =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
>  
>  	LINE6_BITS_CAPTURE_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
> -- 
> 2.1.0
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux