On Sat, Dec 06, 2014 at 04:03:22PM -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] <asn:1>*to > got char *<noident> > > This is done by adding the missing __user attribute on userland pointers inside the LPROC_SEQ_FOPS like macros: > - LPROC_SEQ_FOPS > - LPROC_SEQ_FOPS_RW_TYPE > - LPROC_SEQ_FOPS_WR_ONLY > - LDLM_POOL_PROC_WRITER > > The patch also updates all the functions that are used by this macro: > - lprocfs_wr_* > - *_seq_write > > as well as some helpers used by the previously modified functions (otherwise fixing the sparse warning add some new ones): > - lprocfs_write_frac_helper > - lprocfs_write_helper > - lprocfs_write_u64_helper > > The patch also fixes one __user pointer direct dereference by strncmp in function fld_proc_hash_seq_write. > > Signed-off-by: Tristan Lelong <tristan@xxxxxxxxxx> > --- > Changes in v2: > Use dynamic allocation for 'name' variable instead of having it on the stack, per Greg K-H suggestion. > > Changes in v3: > Rename added variable from 'name' to 'fh_name'. > Revert to a stack declaration of 'fh_name' since it is not 80 bytes but only 8, per Andreas Dilger comment. Hi, I just wanted to follow up on that patch to see if anybody had any comment. Thanks Regards _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
