On 21 December 2014 at 18:57, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote: > Mathieu, > > On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poirier@xxxxxxxxxx wrote: >> From: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> >> >> Fixing errors related to the usage of do {} while (0) loop >> in single statement macros, trailing semicolon in macros and >> trailing whitespace. > > Huh. iirc, I added those do {} while(0)s to keep checkpatch happy. > Either it's gotten smarter, or something is off. Checkpatch apparently changed it's mind. > > At any rate, the whole macro menagerie in here concerns me a bit and I'm > reluctant to change it until I have some time to refresh my memory on > what this code is doing. > > It would be helpful if you could give scripts/objdiff a try on the > before and after effects of your patch. If the object code doesn't > change, then we can be more confident that the patch is just style > changes. Please also check when SKEIN_UNROLL_* is set/unset. You got it. > > I really should put the patch series together to move this driver out of > staging. Then maybe folks will stop running checkpatch against it :-) > > thx, > > Jason. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel