Re: [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type

[Malcolm Priestley <tvboxspy@xxxxxxxxx>]

On 21/12/14 13:56, Mike Krinkin wrote:
> this patch fixes following sparse warnings:
>
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25:    got struct vnt_private *
Good catch

also needed for 3.19

Thanks

Malcolm

> Signed-off-by: Mike Krinkin <krinkin.m.u@xxxxxxxxx>
> ---
>   drivers/staging/vt6655/device_main.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 83e4162..ce616f9 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
>   		if (conf->enable_beacon) {
>   			vnt_beacon_enable(priv, vif, conf);
>
> -			MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> +			MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
> +				      TCR_AUTOBCNTX);
>   		} else {
> -			MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> +			MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
> +				       TCR_AUTOBCNTX);
>   		}
>   	}
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel