On Mon, Dec 15, 2014 at 10:05:34PM +0800, Matthew Tyler wrote: > /* find token length */ > - for (len = 0; str[len] != 0 && !isspace(str[len]) && > - str[len] != '+' && str[len] != '-'; len++); > + len = 0; > + while (str[len] != '\0' && !isspace(str[len]) && > + str[len] != '+' && str[len] != '-') This isn't aligned correctly. I think checkpatch.pl --strict will warn here. It should be: while (str[len] != '\0' && !isspace(str[len]) && str[len] != '+' && str[len] != '-') [tab][tab][space][space][space][space][space][space][space]str[len] ... Otherwise, it looks good. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
