drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static? drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static? drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol 'fpga_mgr_dev_pm_ops' was not declared. Should it be static? Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- fpga-mgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fpga/fpga-mgr.c b/drivers/staging/fpga/fpga-mgr.c index d08cb82..3216276 100644 --- a/drivers/staging/fpga/fpga-mgr.c +++ b/drivers/staging/fpga/fpga-mgr.c @@ -43,7 +43,7 @@ static LIST_HEAD(fpga_manager_list); * * This will be used to initialize framework state */ -int fpga_mgr_low_level_state(struct fpga_manager *mgr) +static int fpga_mgr_low_level_state(struct fpga_manager *mgr) { if (!mgr || !mgr->mops || !mgr->mops->state) return FPGA_MGR_STATE_UNKNOWN; @@ -321,7 +321,7 @@ static const struct attribute_group fpga_mgr_group = { .attrs = fpga_mgr_attrs, }; -const struct attribute_group *fpga_mgr_groups[] = { +static const struct attribute_group *fpga_mgr_groups[] = { &fpga_mgr_group, NULL, }; @@ -362,7 +362,7 @@ static int fpga_mgr_resume(struct device *dev) return 0; } -const struct dev_pm_ops fpga_mgr_dev_pm_ops = { +static const struct dev_pm_ops fpga_mgr_dev_pm_ops = { .suspend = fpga_mgr_suspend, .resume = fpga_mgr_resume, }; _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel