Re: [PATCH v2] Staging: rtl8188eu: {core, hal, include}: Removed inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 29, 2014 at 11:48:07AM +0100, Abel Moyo wrote:
> Removed inline function get_my_bssid and open coded all its references
> 
> Signed-off-by: Abel Moyo <abelmoyo.ab@xxxxxxxxx>
> ---
> Changes in v2:
> 	- Remove inline function entirely and open code the
> 	  implementation instead of replacing __inline with inline
> 
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c    | 57 +++++++++++++++---------
>  drivers/staging/rtl8188eu/core/rtw_wlan_util.c   |  5 ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c     | 20 +++++----
>  drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |  1 -
>  4 files changed, 47 insertions(+), 36 deletions(-)

You obviously didn't test your patch out as it breaks the build in
horrible ways.

ALWAYS test your patches, otherwise you will make maintainers grumpy,
and rightfully so...

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux