On 12/01/2014 02:01 PM, anjana s wrote: > Should I do anything on this further? No. The driver will disappear in 3.19, so there is no point to this patch. BTW, always check the Kconfig to see if a staging driver is marked deprecated. If so, then patches are pointless. Regards, Hans > Looking forward to hear from you. > > On Mon, Dec 1, 2014 at 2:20 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx <mailto:dan.carpenter@xxxxxxxxxx>> wrote: > > On Sun, Nov 30, 2014 at 04:28:02PM +0530, Anjana Sasindran wrote: > > This patch fix a checkpatch.pl <http://checkpatch.pl> error: > > > > ERROR: space prohibited before ')' parenthesis closing > > > > Signed-off-by: Anjana Sasindran <anjanasasindran123@xxxxxxxxx <mailto:anjanasasindran123@xxxxxxxxx>> > > --- > > drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h > > index 0286c95..9490595 100644 > > --- a/drivers/staging/media/omap24xx/v4l2-int-device.h > > +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h > > @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *); > > > > V4L2_INT_WRAPPER_0(dev_init); > > V4L2_INT_WRAPPER_0(dev_exit); > > -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, ); > > +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *); > > Wait, what? The changelog for this is not clear. This looks like > either a bug fix or a bug introducer. > > This driver has been deleted in linux-next anyway so I guess it doesn't > matter. Please work against linux-next. > > regards, > dan carpenter > > > > > -- > Anjana S > Amrita School of Engineering > anjanasasindran123@xxxxxxxxx <mailto:anjanasasindran123@xxxxxxxxx> > > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
