Re: [PATCH] staging: unisys: Remove chanstub files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 07, 2014 at 10:17:40AM -0800, Greg KH wrote:
> On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
> >  While fixing the CamelCase checks for the functions in the chanstub
> >  source and header files, I discovered they are no longer being used.
> >  This patch removes the two chanstub files, and deletes the #include
> >  of these files from uislib.c and uisqueue.c.  It also removes the
> >  chanstub.o from the channels Makefile.
> 
> Are you sure this patch is correct?  You now have no MODULE_LICENSE or
> other MODULE_* information for this module, and you have no
> module_init() or _exit calls.  You might not need the init/exit calls,
> but you will need the MODULE_LICENSE macro.

Given that you seem to be ignoring my emails, I'll just go dump the
pending patches you have sent me for this driver, as there seems to be a
problem in the feedback loop here.

Please resend all of your pending patches after fixing this.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux