On 20/11/14 22:07, H Hartley Sweeten wrote:
Most of the comedi drivers that use the comedi_subdevice 'readback' use the core provided (*insn_read) function, comedi_readback_insn_read(). Modify comedi_alloc_subdev_readback() to automatically default the subdevice (*insn_read) to this function after allocating the 'readback' memory. A couple of the comedi drivers still use a private (*insn_read), move the hook up after the allocation and add a comment for them. Convert some more comedi drivers to use the comedi_subdevice 'readback'. Tidy up/fix the (*insn_write) functions for the ones that don't quite follow the API. H Hartley Sweeten (19): staging: comedi: drivers: have core hook up default (*insn_read) for readback staging: comedi: cb_pcidas64: use subdevice readback for 'caldac_state' staging: comedi: cb_pcidas64: fix calib_write_insn() staging: comedi: cb_pcidas64: use subdevice readback for 'ad8402_state' staging: comedi: cb_pcidas64: fix ad8402_write_insn() staging: comedi: cb_pcidas: remove unnecessary check in caldac_8800_write() staging: comedi: cb_pcidas: fix caldac_write_insn() staging: comedi: cb_pcidas: use subdevice readback for 'caldac_value' staging: comedi: cb_pcidas: fix trimpot_write_insn() staging: comedi: cb_pcidas: use subdevice readback for 'trimpot_value' staging: comedi: cb_pcidas: tidy up dac08_write_insn() staging: comedi: cb_pcidas: use subdevice readback for 'dac08_value' staging: comedi: ni_at_ao: use subdevice readback for 'caldac' staging: comedi: ni_labpc_common: move calib readback value check/save to (*insn_write) staging: comedi: ni_labpc_common: use subdevice readback for 'caldac' staging: comedi: ni_labpc_common: introduce labpc_ao_write() staging: comedi: ni_labpc_common: use subdevice readback for analog outputs staging: comedi: ni_labpc_common: use subdevice readback for eeprom staging: comedi: ni_labpc_common: use comedi_timeout() when writing to eeprom drivers/staging/comedi/drivers.c | 3 + drivers/staging/comedi/drivers/addi_apci_3120.c | 1 - drivers/staging/comedi/drivers/addi_apci_3501.c | 1 - drivers/staging/comedi/drivers/addi_apci_3xxx.c | 1 - drivers/staging/comedi/drivers/adl_pci6208.c | 1 - drivers/staging/comedi/drivers/adl_pci9111.c | 1 - drivers/staging/comedi/drivers/adl_pci9118.c | 1 - drivers/staging/comedi/drivers/aio_aio12_8.c | 1 - drivers/staging/comedi/drivers/amplc_pci224.c | 1 - drivers/staging/comedi/drivers/amplc_pci230.c | 1 - drivers/staging/comedi/drivers/cb_das16_cs.c | 1 - drivers/staging/comedi/drivers/cb_pcidas.c | 188 ++++++++++------------- drivers/staging/comedi/drivers/cb_pcidas64.c | 115 +++++++------- drivers/staging/comedi/drivers/cb_pcimdas.c | 1 - drivers/staging/comedi/drivers/cb_pcimdda.c | 3 +- drivers/staging/comedi/drivers/dac02.c | 1 - drivers/staging/comedi/drivers/daqboard2000.c | 1 - drivers/staging/comedi/drivers/das08.c | 1 - drivers/staging/comedi/drivers/das16.c | 1 - drivers/staging/comedi/drivers/das6402.c | 3 +- drivers/staging/comedi/drivers/dmm32at.c | 1 - drivers/staging/comedi/drivers/dt2801.c | 1 - drivers/staging/comedi/drivers/dt2811.c | 1 - drivers/staging/comedi/drivers/dt282x.c | 1 - drivers/staging/comedi/drivers/dt3000.c | 1 - drivers/staging/comedi/drivers/dt9812.c | 3 +- drivers/staging/comedi/drivers/fl512.c | 1 - drivers/staging/comedi/drivers/icp_multi.c | 1 - drivers/staging/comedi/drivers/ii_pci20kc.c | 1 - drivers/staging/comedi/drivers/me4000.c | 1 - drivers/staging/comedi/drivers/me_daq.c | 1 - drivers/staging/comedi/drivers/mf6x4.c | 1 - drivers/staging/comedi/drivers/multiq3.c | 1 - drivers/staging/comedi/drivers/ni_670x.c | 1 - drivers/staging/comedi/drivers/ni_at_ao.c | 56 +++---- drivers/staging/comedi/drivers/ni_atmio16d.c | 1 - drivers/staging/comedi/drivers/ni_labpc.h | 6 - drivers/staging/comedi/drivers/ni_labpc_common.c | 144 +++++++---------- drivers/staging/comedi/drivers/ni_mio_common.c | 1 - drivers/staging/comedi/drivers/pcl711.c | 1 - drivers/staging/comedi/drivers/pcl726.c | 1 - drivers/staging/comedi/drivers/pcl812.c | 1 - drivers/staging/comedi/drivers/pcl818.c | 1 - drivers/staging/comedi/drivers/pcmda12.c | 3 +- drivers/staging/comedi/drivers/pcmmio.c | 1 - drivers/staging/comedi/drivers/quatech_daqp_cs.c | 1 - drivers/staging/comedi/drivers/rtd520.c | 1 - drivers/staging/comedi/drivers/rti800.c | 1 - drivers/staging/comedi/drivers/rti802.c | 1 - drivers/staging/comedi/drivers/s526.c | 1 - drivers/staging/comedi/drivers/s626.c | 1 - drivers/staging/comedi/drivers/usbdux.c | 3 +- drivers/staging/comedi/drivers/usbduxsigma.c | 3 +- 53 files changed, 230 insertions(+), 341 deletions(-)
I suggested a minor change to patch 01, but it's not that important. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
