Set default parport module param value to DEFAULT_PARPORT so that a if-block can be avoided. Signed-off-by: Mariusz Gorski <marius.gorski@xxxxxxxxx> Acked-by: Willy Tarreau <w@xxxxxx> --- drivers/staging/panel/panel.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index c6eeddf..3dd318a 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -429,7 +429,7 @@ static struct timer_list scan_timer; MODULE_DESCRIPTION("Generic parallel port LCD/Keypad driver"); -static int parport = -1; +static int parport = DEFAULT_PARPORT; module_param(parport, int, 0000); MODULE_PARM_DESC(parport, "Parallel port index (0=lpt1, 1=lpt2, ...)"); @@ -2231,9 +2231,6 @@ static int panel_init(void) if (lcd_type < 0) lcd_type = lcd_enabled; - if (parport < 0) - parport = DEFAULT_PARPORT; - /* take care of an eventual profile */ switch (profile) { case PANEL_PROFILE_CUSTOM: -- 2.1.3 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel