On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote: > Rework lcd_init method to make it a little bit more clear about > the precedence of the params, move LCD geometry and pins layout > to the LCD struct and thus make the LCD-related module params > effectively read-only. > > Signed-off-by: Mariusz Gorski <marius.gorski@xxxxxxxxx> Acked-by: Willy Tarreau <w@xxxxxx> I like this refactoring. However I don't know if you got your LCD module to work or not, but for such important changes you should definitely test the code, since it's very easy to introduce minor bugs or even to fix a bug that used to make the whole driver work... Willy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
