Re: [PATCH 1/1] staging: unisys: small parser.c bug fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 14, 2014 at 05:43:24PM +0300, Dan Carpenter wrote:
> > @@ -90,7 +88,6 @@ parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
> >  			       __func__,
> >  			       (unsigned long long)addr, (ulong)bytes);
> >  			rc = NULL;
> > -			goto cleanups;

Also after this patch then every reference to "rc" in this function
should be deleted.  You forgot to delete one here.  It doesn't cause a
bug but it's messy to leave unneeded variables.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux