Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi ZubairLK:
   Thanks for your review.
On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote:
Hi Andy,

Nice work on this patch series. Its getting better and better :).

On 14/11/14 03:27, Andy Yan wrote:
hdmi phy clock symbol and transmission termination value
can adjust platform specific to get the best SI
						^Is this signal integrity?
   yes , SI  is signal integrity, such as eye diagram measurement

Are these two disjoint features in separate patches?

also add mode_valid interface for some platform may not support
all the display mode
Sounds like another separate patch to me. :)
   they can seperate

Also, This series is becoming quite large. With major changes and fixes mixed together.

Patch 3 splits imx-drm.
Patch 4 moves dw-drm out of imx-drm folder.
Patch 7 adds binding
Patch 9 converts to drm bridge.

Can these be placed together easily?
And in the start. i.e. patch 1, 2, 3, 4,

Then all fixes etc can come afterwards?

It helps when checking histories later as to how a driver was made and how fixes happened.

Especially when file moves happen..
  Do you mean we can rearrange the patch series?
  put patch 3, 4 ,7, 9 together  one bye one
  than followed by the fixes patches  5 ,6, 8, 11 ?

Cheers,
ZubairLK

Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>

---

Changes in v10:
- split generic dw_hdmi.c improvements from patch#11 (add rk3288 support)

Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

  drivers/gpu/drm/bridge/dw_hdmi.c      | 29 +++++++++++++++++++++++++++--
  drivers/staging/imx-drm/dw_hdmi-imx.c | 10 +++++++++-
  include/drm/bridge/dw_hdmi.h          |  7 +++++++
  3 files changed, 43 insertions(+), 3 deletions(-)

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip





_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux