>> @@ -487,8 +488,7 @@ static void rtw_usb_if1_deinit(struct adapter *if1)
>> DBG_88E("+r871xu_dev_remove, hw_init_completed=%d\n",
>> if1->hw_init_completed);
>> rtw_free_drv_sw(if1);
>> - if (pnetdev)
>> - rtw_free_netdev(pnetdev);
>> + rtw_free_netdev(pnetdev);
>
> I still feel that hiding the if statement inside the function call makes
> the code more subtle and it is a bad harmful thing to do.
I find your feedback interesting.
> This is especially true if you have trained yourself to know that
> free_netdev() can't accept NULL pointers.
Do you need to adjust your concerns a bit over time when function variants
provide a corresponding safety check in their implementations?
Regards,
Markus
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
