Re: [PATCH 10/10] staging: unisys: PARSER_WHICH_STRING typedef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 11, 2014 at 09:46:19AM -0500, Jeffrey wrote:
> Removed the typedef PARSER_WHICH_STRING in parser.h and added enum
> in front of it at every instance of the variable in parser.c, and
> parser.h
> 
> Signed-off-by: Jeffrey <Jeffrey.Brown@xxxxxxxxxx>
> ---
>  drivers/staging/unisys/visorchipset/parser.c | 2 +-
>  drivers/staging/unisys/visorchipset/parser.h | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorchipset/parser.c b/drivers/staging/unisys/visorchipset/parser.c
> index c38de48..20df56f 100644
> --- a/drivers/staging/unisys/visorchipset/parser.c
> +++ b/drivers/staging/unisys/visorchipset/parser.c
> @@ -211,7 +211,7 @@ parser_id_get(struct parser_context_tag *ctx)
>  
>  void
>  parser_param_start(struct parser_context_tag *ctx,
> -		   PARSER_WHICH_STRING which_string)
> +		   enum PARSER_WHICH_STRING which_string)

Change the PARSER_WHICH_STRING from all caps at the same time.  Also
what does that name even mean?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux