> -----Original Message----- > From: Vitaly Kuznetsov > Sent: Tuesday, November 11, 2014 0:37 AM > To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman > Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Dexuan Cui > Subject: [PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors > > When ioctl(fd, FIFREEZE, 0) results in an error we cannot report it > to syslog instantly since that can cause write to a frozen disk. > However, the name of the filesystem which caused the error and errno > are valuable and we would like to get a nice human-readable message > in the log. Save errno before calling vss_operate(VSS_OP_THAW) and > report the error right after. > > Unfortunately, FITHAW errors cannot be reported the same way as we > need to finish thawing all filesystems before calling syslog(). > > We should also avoid calling endmntent() for the second time in > case we encountered an error during freezing of '/' as it usually > results in SEGSEGV. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> > --- > tools/hv/hv_vss_daemon.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) Hi Vitaly, Thanks for the patch -- it does improve the error handling! Acked-by: Dexuan Cui <decui@xxxxxxxxxxxxx> -- Dexuan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
