On 06/11/14 23:03, Greg Kroah-Hartman wrote: > On Thu, Nov 06, 2014 at 11:56:05PM +0100, kris@xxxxxxxxxxx wrote: >> From: Krzysztof Konopko <kris@xxxxxxxxxxx> >> >> Several stylistics problems are reported by scripts/checkpatch.pl run on >> rtw_led.*: >> >> * FSF_MAILING_ADDRESS >> >> Free Software Foundation's mailing address should not be included in >> the sample GPL notice. >> >> * LINE_SPACING >> >> Missing a blank line after declarations. >> >> * leading spaces >> >> * a typo >> >> * any too long lines changed with this patch >> >> All of the problems above are fixed with this patch. > > Each patch should only do 1 thing, so please break this up into multiple > patches, each only doing 1 thing, in a patch series, and resend so it > can be applied. > > thanks, > > greg k-h > Thanks for having a look. I've resent it in a series of three patches already. A bit of mess the way it appears on some on-line mailing list readers (gmane for example) as I used `--chain-reply-to` (while writing this I just bumped onto `Documentation/development-process/5.Posting` again, hm... not sure if this was the right thing to do). Also I've been trying to create a separate email client set-up to what I do for my everyday work with Git patches and reviews. But I gave up and fell back to what works for me on everyday basis :) I'll keep trying to get it right :) Cheers, Kris _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
