On Thu, Nov 06, 2014 at 01:17:56PM -0600, Ken Cox wrote: > >There are also other checkpatch errors in this patch, which makes me not > >want to take it at all, as you would now just be required to send more > >fixes for the file. So why not fix things up right the first time? > The only checkpatch warnings I get are: > -a warning about the MAINTAINERS file not being updated when adding a new > file. MAINTAINERS already has an entry that covers this file > > -warnings about lines over 80 characters. These are strings for error > messages that make the line exceed 80 characters. I thought this was OK. > Those "error messages" should use the "correct" printk-like calls, and then the checkpatch messages will go away :) So no, it's not ok as-is, please fix up. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
