Dan, The CamelCase version is what is currently present in our source. I have not addressed/fixed those checks yet. With the members as busNo and deviceNo, the kernel builds cleanly. I'm not sure why they showed up as non-CamelCase in the diff. Ken -----Original Message----- From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] Sent: Thursday, November 06, 2014 10:55 AM To: Depro, Kenneth J Cc: gregkh@xxxxxxxxxxxxxxxxxxx; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; *S-Par-Maintainer Subject: Re: [PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c On Thu, Nov 06, 2014 at 10:33:28AM -0500, Ken Depro wrote: > - LOGINF("virtpcidev bus_no<<%d>>devNo<<%d>>", virtpcidev->bus_no, > - virtpcidev->device_no); > - virthbainfo = (struct virthba_info *) scsihost->hostdata; > + LOGINF("virtpcidev busNo<<%d>>devNo<<%d>>", virtpcidev->busNo, > + virtpcidev->deviceNo); That's odd. Some struct members are renamed. Does this introduce a compile problem or does it fix one? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
