On Wed, 5 Nov 2014 17:00:25 +0200 Sakari Ailus <sakari.ailus@xxxxxx> wrote: > Hi, > > On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote: > > Well, I gave two alternatives :-) > > > > Both are fine as far as I am concerned, but it would be nice to hear > > what others think. > > In fact I think both are good options. :-) > > I'd perhaps lean towards the latter, for it has the benefit of pushing to > use the new definitions and the old ones can be deprecated (and eventually > removed in year 2030 or so ;)). > > Either way, preprocessor macros should be used instead of an enum since that > way it's possible to figure out at that phase whether something is defined > or not. There is for enums, too, but it results in a compilation error... > I don't get that last part :-). -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel