On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: > On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: > > Fix the implementation of a single-open policy for both > > devices (lcd and keypad) by using atomic_t instead of plain ints. > > > > This seems like it might be a real life bug that you have experienced? No, I don't think it might really happen in real life. I found it just by reading the code. A similar solution is used in Chapter 6 of the LDD3 book, so I thought it might be a good idea to fix is here. > The changelog should tell the user visible effects of the bug. If you > have some dmesg output that would be helpful as well. Nope, I can't really reproduce it ATM. > regards, > dan carpenter > Cheers, Mariusz _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel