The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.
Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
---
drivers/staging/dgap/dgap.c | 23 -----------------------
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 293dc33..aa393d2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7019,23 +7019,6 @@ static struct pci_driver dgap_driver = {
};
/*
- * dgap_init_globals()
- *
- * This is where we initialize the globals from the static insmod
- * configuration variables. These are declared near the head of
- * this file.
- */
-static void dgap_init_globals(void)
-{
- unsigned int i;
-
- for (i = 0; i < MAXBOARDS; i++)
- dgap_board[i] = NULL;
-
- init_timer(&dgap_poll_timer);
-}
-
-/*
* Start of driver.
*/
static int dgap_start(void)
@@ -7044,12 +7027,6 @@ static int dgap_start(void)
unsigned long flags;
struct device *device;
- /*
- * make sure that the globals are
- * init'd before we do anything else
- */
- dgap_init_globals();
-
dgap_numboards = 0;
pr_info("For the tools package please visit http://www.digi.com\n";);
--
1.7.1
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
