Re: [PATCH v2] Fix error handling in dgnc_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 19, 2014 at 02:37:28AM +0530, Devendra Naga wrote:
> The error_handling for class_create, device_create are taken care
> by the respective goto statements. The failure code from class_create and
> device_create are assigned to the variable rc to return a proper value.
> 
> Also removed the rc initialisation to 0 as it gets changed in the call to
> register_chrdev.
> 
> Signed-off-by: Devendra Naga <devendranaga4@xxxxxxxxx>
> ---
> 
>  Changes since v2: (added solutions for Dan's comments)
> 
>  1. removed error message print
>  2. added error handling in device_create
>  3. added goto err_device_destroy when dgnc_tty_preinit fails

Doesn't apply to my tree :(
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux