On Fri, Oct 31, 2014 at 09:57:31AM -0400, Benjamin Romer wrote:
> Get rid of the typedef and use struct visorchipset_internalport_info and fix
> CamelCase member names:
>
> switchNo => switch_no
> internalPortNo => internal_port_no
> busNo => bus_no
> devNo => dev_no
> Reserved1 => reserved1
> Reserved2 => reserved2
> pendingMsgHdr => pending_msg_hdr
> procObject => proc_object
>
> Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> ---
> drivers/staging/unisys/visorchipset/visorchipset.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorchipset/visorchipset.h
> index e20eb10..7d3b2c1 100644
> --- a/drivers/staging/unisys/visorchipset/visorchipset.h
> +++ b/drivers/staging/unisys/visorchipset/visorchipset.h
> @@ -200,18 +200,18 @@ struct visorchipset_externalport_info {
> /** Attributes for a particular Supervisor internal port, which is how a
> * device connects to a particular switch.
> */
> -typedef struct {
> - u32 switchNo;
> - u32 internalPortNo;
> +struct visorchipset_internalport_info {
> + u32 switch_no;
> + u32 internal_port_no;
> struct visorchipset_state state;
> - u32 busNo; /* valid only when state.attached == 1 */
> - u32 devNo; /* valid only when state.attached == 1 */
> - u64 Reserved1;
> - u32 Reserved2; /* CONTROLVM_ID */
> - struct controlvm_message_header pendingMsgHdr;
> - MYPROCOBJECT *procObject;
> -
> -} VISORCHIPSET_INTERNALPORT_INFO;
> + u32 bus_no; /* valid only when state.attached == 1 */
> + u32 dev_no; /* valid only when state.attached == 1 */
> + u64 reserved1;
> + u32 reserved2; /* CONTROLVM_ID */
> + struct controlvm_message_header pending_msg_hdr;
> + MYPROCOBJECT *proc_object;
> +
> +};
>
> /* These functions will be called from within visorchipset when certain
> * events happen. (The implementation of these functions is outside of
And here, deleted?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
