Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 01, 2014 at 10:09:39PM +0800, Chen Weixiang wrote:
> On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote:
> > many whitespace errors in the patch.
> > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> > 
> > thanks
> > sudip
> > 
> 
> Hi sudip,
> 
> Yes, I also run checkpatch.pl on this patch, and got several
> errors/warnings. But those errors/warnings are not related to
> spaces around '=', '<' and '==' anymore.
> 
> I thought it's better to fix one code style error/warning in
> one patch, and put the code style error/warning to Subject line.
> It's much clear, isn't it?
yes , it is . :)
i was also trying to generate a similar patch, which will not give checkpatch error,
  but it seems the original file code indention is not done with tabs. so those errors will be there if you want to keep the same indention.

thanks
sudip

> 
> Thanks.
> 
> -- 
> Best regards,
> Chen Weixiang (Alex)
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux