"Sharma, Sanjeev" <Sanjeev_Sharma@xxxxxxxxxx> writes: > -----Original Message----- > From: Jes Sorensen [mailto:Jes.Sorensen@xxxxxxxxxx] > Sent: Monday, October 27, 2014 2:13 PM > To: Sharma, Sanjeev > Cc: Larry.Finger@xxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > linux-wireless@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch. > > Sanjeev Sharma <sanjeev_sharma@xxxxxxxxxx> writes: >> This is a patch to the rtw_cmd.c file that fixes Error reported by >> checkpatch. >> >> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@xxxxxxxxxx> >> --- >> drivers/staging/rtl8723au/core/rtw_cmd.c | 83 >> +++++++++++++++----------------- >> 1 file changed, 40 insertions(+), 43 deletions(-) >> >> diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c >> b/drivers/staging/rtl8723au/core/rtw_cmd.c >> index 4eaa502..c1f6254 100644 >> --- a/drivers/staging/rtl8723au/core/rtw_cmd.c >> +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c >> @@ -957,7 +957,7 @@ static void traffic_status_watchdog(struct rtw_adapter *padapter) >> /* check traffic for powersaving. */ >> if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + >> pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > 8) || >> - pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2) >> + pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2) >> bEnterPS = false; >> else >> bEnterPS = true; > > This makes the line longer than 80 characters, that is worse than the 'problem' you are fixing. > > Jes > > Hello jes, > > How it can be worse because checkpatch treating this as an Error and > line longer than 80 character is warning reported by checkpatch and I > could see that in entire staging directory, > every maintainer most of the time ignore the 80 column limit and give > priority to Error. > > Please let me know your comment . > > Sanjeev Sharma checkpatch has it's ideas, doesn't mean it's blindly right at all times. In this particular case it keeps the code more readable to keep it below 80 characters than it does to add those two blanks and make the line longer. I agree the long variable names are nasty, and it doesn't help they were done in StUdLyCaPs. If you want to attack it from that front, please go ahead. However, on formatting, please respond with proper email using proper quoting when replying. Thanks, Jes _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
