Re: [PATCH 1/3] staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 27, 2014 at 02:17:38PM +0300, Dan Carpenter wrote:
> On Sun, Oct 26, 2014 at 10:56:34AM -0700, Insop Song wrote:
> > Devendra
> > 
> > Since these are small changes, I want one patch set instead of three unless Greg says otherwise.
> > 
> 
> Normally in staging/ we would insist on three patches for this.  The one
> thing per patch rule is a bit ambiguous at times but certainly the first
> patch has to go by itself.  The other two patches could maybe be called
> one thing as in "fix -w1 warnings" but really Devendra did it the most
> obviously correct way.
Okay.
I still think that two patches for warnings fix is overkill.
Could you combine two warning patches into one, so that total two patches (err/r
clean up and warning fix)

Regards,

Insop
> 
> regards,
> dan carpenter
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux