On Mon, Oct 27, 2014 at 03:12:57PM +0300, Dan Carpenter wrote: > On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote: > > On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote: > > > On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote: > > > > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > > > > if (tmp8_a != (tmp8|BIT(2))) > > > > goto exit_fail; > > > > > > > > - tmp32 = r8712_read32(padapter, TCR); > > > > + r8712_read32(padapter, TCR); > > > > > > I wonder if we actually need to call r8712_read32() here? It's not > > > clear. The changelog should say one way or the other. Maybe something > > > like "I left a call to r8712_read32(padapter, TCR) because I didn't know > > > if it had side effects". When you note down questions you have in the > > > changelog that helps reviewers. > > sure. i will resend it with modified commit log. > > r8712_read32() is ultimately calling usb_read32() which is again calling r8712_usbctrl_vendorreq(). > > this r8712_usbctrl_vendorreq() is communicating through the usb bus and is sending and receiving the control msg. > > that is why i didnot remove it. > > Yeah. I'm 95% sure it's not needed, but I suppose it's better to err > on the side of caution. i have already sent the v2 with modified commit log. thanks sudip > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
