Re: [PATCH] staging: comedi: ni_mio_common: remove deadcode in ni_cdio_cmdtest()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/10/14 23:04, H Hartley Sweeten wrote:
Reported by: coverity (CID 142967)

Should be a dash in "Reported by".

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
  drivers/staging/comedi/drivers/ni_mio_common.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 4a1d0ba..4672a14 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3490,9 +3490,6 @@ static int ni_cdio_cmdtest(struct comedi_device *dev,
  	/* Step 2a : make sure trigger sources are unique */
  	/* Step 2b : and mutually compatible */

-	if (err)
-		return 2;
-
  	/* Step 3: check if arguments are trivially valid */

  	err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);


Other than the issue on the "Reported by" line...

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux