On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > ^ > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > ^ > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT > is enabled, since the driver is known to be broken for 64 bit arch's. > > CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > CC: Joe Perches <joe@xxxxxxxxxxx> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> Greg- I have also submitted a patch to remove this driver entirely. So if you choose to apply the patch to remove the driver, then you can disregard this patch. > --- > v2: change fix from using typecast u64 in the code to altering Kconfig to > prevent the driver from compiling on 64 bit arch's based on feedback > > drivers/staging/bcm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig > index 8acf4b2..273b328 100644 > --- a/drivers/staging/bcm/Kconfig > +++ b/drivers/staging/bcm/Kconfig > @@ -1,6 +1,6 @@ > config BCM_WIMAX > tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" > - depends on USB && NET > + depends on USB && NET && !64BIT > help > This is an experimental driver for the Beceem WIMAX chipset used > by Sprint 4G.
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
