On Tue, 2014-10-07 at 20:42 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -541,15 +540,16 @@ u8 r8712_efuse_map_write(struct _adapter *padapter, u16 addr, u16 cnts,
[]
> +
> + if ((data[idx] != pktdata[i]) || (data[idx+1] !=
> + pktdata[i+1])) {
Just an fyi: (and I know you didn't introduce this)
Maximal fill to 80 columns is not always the most
readable for humans.
This sort of test is generally better where the
individual tests are written on separate lines like:
if ((data[idx] != pktdata[i]) ||
(data[idx+1] != pktdata[i+1])) {
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
